-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace ESLint and Prettier to Biome #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1sk9
force-pushed
the
replace-eslint-and-prettier-to-biome
branch
from
July 20, 2024 11:51
59bd1d9
to
fe4c76d
Compare
m1sk9
force-pushed
the
replace-eslint-and-prettier-to-biome
branch
from
July 20, 2024 12:02
acf2414
to
1d29f95
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
===========================================
- Coverage 66.21% 51.62% -14.60%
===========================================
Files 111 110 -1
Lines 8330 8295 -35
Branches 759 729 -30
===========================================
- Hits 5516 4282 -1234
- Misses 2814 4013 +1199 ☔ View full report in Codecov by Sentry. |
laminne
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
動きそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#568
What does this PR do?
Pulsate で使用している ESLint, Prettier を Biome に置き換えます.
recommend
) を使用しています.Additional information
Linter で警告されたルールについては処置がディスカッション内で以下のように処置するようにしました.
noUnreachableSuper
: 採用. この PR 内で修正します.noShadowRestrictedNames
: 無効.noNonNullAssertion
: 一時的なもののため, コメントで無効にします.